From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: avoid unclaimed registers when capturing the error state
Date: Fri, 1 Nov 2013 19:28:05 +0100 [thread overview]
Message-ID: <20131101182805.GP4167@phenom.ffwll.local> (raw)
In-Reply-To: <1383319928-2883-1-git-send-email-przanoni@gmail.com>
On Fri, Nov 01, 2013 at 01:32:08PM -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Even though we only check for unclaimed registers while we're writing
> registers, if we read a bad register we'll still trigger a CPU error
> interrupt, and we'll print an "Unclaimed register" DRM_ERROR due to
> that. To avoid this error, just avoid touching power domains that are
> not enabled.
>
> Use kzalloc so we're sure all the disabled domains will be zeroed on
> the error state file. We already print the information that is enough
> to discover if the power well is enabled on the error state file, so
> this should not be a problem.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69747
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-11-01 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 15:32 [PATCH] drm/i915: avoid unclaimed registers when capturing the error state Paulo Zanoni
2013-11-01 18:28 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-20 17:09 Paulo Zanoni
2014-01-07 14:07 ` Imre Deak
2014-06-02 13:35 ` Chris Wilson
2014-06-02 14:02 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101182805.GP4167@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox