From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: avoid unclaimed registers when capturing the error state Date: Fri, 1 Nov 2013 19:28:05 +0100 Message-ID: <20131101182805.GP4167@phenom.ffwll.local> References: <1383319928-2883-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 57D82F0762 for ; Fri, 1 Nov 2013 11:27:40 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id l10so2162682eei.9 for ; Fri, 01 Nov 2013 11:27:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1383319928-2883-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 01, 2013 at 01:32:08PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Even though we only check for unclaimed registers while we're writing > registers, if we read a bad register we'll still trigger a CPU error > interrupt, and we'll print an "Unclaimed register" DRM_ERROR due to > that. To avoid this error, just avoid touching power domains that are > not enabled. > > Use kzalloc so we're sure all the disabled domains will be zeroed on > the error state file. We already print the information that is enough > to discover if the power well is enabled on the error state file, so > this should not be a problem. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69747 > Signed-off-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch