From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 2/2] drm/i915: Make intel_dp_is_edp() less specific Date: Mon, 4 Nov 2013 17:30:50 +0100 Message-ID: <20131104163050.GL4167@phenom.ffwll.local> References: <20131101102509.6ba6861d@jbarnes-desktop> <1383330728-16093-1-git-send-email-ville.syrjala@linux.intel.com> <1383330728-16093-2-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by gabe.freedesktop.org (Postfix) with ESMTP id E58D1FA91F for ; Mon, 4 Nov 2013 08:30:26 -0800 (PST) Received: by mail-ee0-f46.google.com with SMTP id b57so839736eek.19 for ; Mon, 04 Nov 2013 08:30:22 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Nov 04, 2013 at 02:08:19PM -0200, Paulo Zanoni wrote: > 2013/11/1 : > > From: Ville Syrj=E4l=E4 > > > > All the bits in the VBT child device type have some speciifc meaning, > > so looking for an exact match isn't always the right thing. On some > > VLVs for example the device type for eDP panels is 0x1806. > > > > If we mask out the bits that could concievably change between different > > eDP panels, we are left with the set of bits that should still > > tell us if the port is eDP or not. > > > > v2: Use the named bits for VBT child device type > = > We go with this patch until they start creating analog eDP panels or > whatever else their creative minds come up with :) > = > Reviewed-by: Paulo Zanoni Both merged, thanks for patches&review. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch