Re: [PATCH 63/62] drm/i915/bdw: Enable trickle feed on Broadwell

Damien Lespiau
2013-11-04T15:05:58Z

On Sun, Nov 03, 2013 at 01:47:27PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Like on HSW, trickle feed should always be enabled on BDW.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

--
Damien

> ---
> Not sure this applies directly, I just put it together on top of -nightly.
> Thus it's not even compile tested.
>
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_sprite.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index f34252d..4539550 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2156,7 +2156,7 @@ static int ironlake_update_plane(struct drm_crtc *crtc,
> else
> dspcntr &= ~DISPPLANE_TILED;
>
> - if (IS_HASWELL(dev))
> + if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> dspcntr &= ~DISPPLANE_TRICKLE_FEED_DISABLE;
> else
> dspcntr |= DISPPLANE_TRICKLE_FEED_DISABLE;
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 8afaad6..2bcee75 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -260,7 +260,7 @@ ivb_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
> if (obj->tiling_mode != I915_TILING_NONE)
> sprctl |= SPRITE_TILED;
>
> - if (IS_HASWELL(dev))
> + if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
> else
> sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
> --
> 1.8.1.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx