Re: [PATCH 47/62] drm/i915/bdw: check DPD on port D when setting the DDI buffers

Ben Widawsky
2013-11-05T00:46:31Z

On Sat, Nov 02, 2013 at 09:07:45PM -0700, Ben Widawsky wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Use the eDP values on platforms where port D is eDP. This doesn't
> affect Haswell since it uses the same DDI buffer values for eDP and
> DP.
>
> Reviewed-by: Art Runyan <arthur.j.runyan@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 3868ed9..a4ddc7f 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -169,9 +169,14 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port)
> break;
> case PORT_B:
> case PORT_C:
> - case PORT_D:
> ddi_translations = ddi_translations_dp;
> break;
> + case PORT_D:
> + if (intel_dpd_is_edp(dev))
> + ddi_translations = ddi_translations_edp;
> + else
> + ddi_translations = ddi_translations_dp;
> + break;
> case PORT_E:
> ddi_translations = ddi_translations_fdi;
> break;

46 & 47 are:
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

--
Ben Widawsky, Intel Open Source Technology Center