Re: [PATCH 37/62] drm/i915/bdw: pretend we have LPT LP on Broadwell

Ville Syrjälä
2013-11-03T11:19:21Z

On Sat, Nov 02, 2013 at 09:07:35PM -0700, Ben Widawsky wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> The platforms we currently have all have LPT LP on them. As such, we
> have no way to identify the new WPT PCH that will ship with Broadwell.
>
> NOTE: For all purposes relevant to the driver that this point, LPT and
> WPT are equivalent. Therefore there should be no need to actually change
> this for some time.
>
> v2: Don't assign dev_priv->num_pch_pll any more.
>
> v3: Rebase on top of the PCH detection changes for virtualized
> enviroments.
>
> v4 (Ben): Wrote commit message
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> (v1)
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---

I would have probably placed the hack to the if (!pch) block in the
end, but since it's a hack anyway I guess it's good enough.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> drivers/gpu/drm/i915/i915_drv.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c86d44b..590d999 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -453,6 +453,12 @@ void intel_detect_pch(struct drm_device *dev)
> DRM_DEBUG_KMS("Found LynxPoint LP PCH\n");
> WARN_ON(!IS_HASWELL(dev));
> WARN_ON(!IS_ULT(dev));
> + } else if (IS_BROADWELL(dev)) {
> + dev_priv->pch_type = PCH_LPT;
> + dev_priv->pch_id =
> + INTEL_PCH_LPT_LP_DEVICE_ID_TYPE;
> + DRM_DEBUG_KMS("This is Broadwell, assuming "
> + "LynxPoint LP PCH\n");
> } else {
> goto check_next;
> }
> --
> 1.8.4.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC