Re: [PATCH 04/62] [v6] drm/i915/bdw: Add device IDs

Ben Widawsky
2013-11-04T16:56:15Z

On Mon, Nov 04, 2013 at 02:49:21PM +0000, Chris Wilson wrote:
> On Sun, Nov 03, 2013 at 04:36:58PM -0800, Ben Widawsky wrote:
> > v2: Squash in "drm/i915/bdw: Add BDW to the HAS_DDI check" as
> > suggested by Damien.
> >
> > v3: Squash in VEBOX enabling from Zhao Yakui <yakui.zhao@intel.com>
> >
> > v4: Rebase on top of Jesse's patch to extract all pci ids to
> > include/drm/i915_pciids.h.
> >
> > v4: Replace Halo by its marketing moniker Iris. Requested by Ben.
> >
> > v5: Switch from info->has*ring to info->ring_mask.
> >
> > v6: Add 0x16X2 variant (which is newer than this patch)
> > Rename to use new naming scheme (Chris)
> > Remove Simulator PCI ids. These snuck in during rebase (Chris)
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> As a paranoid question, are we sure we have all pci-ids reserved?
>

I'll never say I am sure. This includes everything in the bspec, and
ones which aren't supposed to ship. I feel bad about adding those, since
in theory - they could end up in some other product. Since we saw it
happen on HSW though, I figured better safe than sorry.

>
--
Ben Widawsky, Intel Open Source Technology Center