From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 47/62] drm/i915/bdw: check DPD on port D when setting the DDI buffers Date: Mon, 4 Nov 2013 16:46:29 -0800 Message-ID: <20131105004628.GD9345@bwidawsk.net> References: <1383451680-11173-1-git-send-email-benjamin.widawsky@intel.com> <1383451680-11173-48-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id C252AEF187 for ; Mon, 4 Nov 2013 16:46:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <1383451680-11173-48-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Sat, Nov 02, 2013 at 09:07:45PM -0700, Ben Widawsky wrote: > From: Paulo Zanoni > > Use the eDP values on platforms where port D is eDP. This doesn't > affect Haswell since it uses the same DDI buffer values for eDP and > DP. > > Reviewed-by: Art Runyan > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_ddi.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index 3868ed9..a4ddc7f 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -169,9 +169,14 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port) > break; > case PORT_B: > case PORT_C: > - case PORT_D: > ddi_translations = ddi_translations_dp; > break; > + case PORT_D: > + if (intel_dpd_is_edp(dev)) > + ddi_translations = ddi_translations_edp; > + else > + ddi_translations = ddi_translations_dp; > + break; > case PORT_E: > ddi_translations = ddi_translations_fdi; > break; 46 & 47 are: Reviewed-by: Ben Widawsky -- Ben Widawsky, Intel Open Source Technology Center