From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/vlv: use PIPE_START_VBLANK interrupts on VLV Date: Wed, 6 Nov 2013 08:40:35 +0100 Message-ID: <20131106074035.GI1775@phenom.ffwll.local> References: <1383695281-1189-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 00900FA6C2 for ; Tue, 5 Nov 2013 23:40:07 -0800 (PST) Received: by mail-ea0-f172.google.com with SMTP id r16so4780092ead.31 for ; Tue, 05 Nov 2013 23:40:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <1383695281-1189-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 05, 2013 at 03:48:01PM -0800, Jesse Barnes wrote: > This fixes a mismatch between our vblank enable code and our IRQ > handler. Also, since vblank start events come in before page flips > reliably, it also fixes the kms_flip plain-flip test on my BYT system. > = > Spotted-by: Ville Syrj=E4l=E4 > Signed-off-by: Jesse Barnes So kms_flip isn't totally crap I hear? One problem is that the iosf bug is blocking QA's ability to use kms_flip as a regression tests. I wonder a bit whether we need to split out the results as subtests so that each connector type can be tracked individually. The problem with that is that we'd have unstable subtest names, which is a bit ugly ... Good ideas highly welcome. Picked up for -fixes, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_= irq.c > index 2a44816..32c9c8d 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1353,7 +1353,7 @@ static irqreturn_t valleyview_irq_handler(int irq, = void *arg) > spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags); > = > for_each_pipe(pipe) { > - if (pipe_stats[pipe] & PIPE_VBLANK_INTERRUPT_STATUS) > + if (pipe_stats[pipe] & PIPE_START_VBLANK_INTERRUPT_STATUS) > drm_handle_vblank(dev, pipe); > = > if (pipe_stats[pipe] & PLANE_FLIPDONE_INT_STATUS_VLV) { > -- = > 1.8.4.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch