From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/4] drm/i915: Add support for VLV GPLL bypass Date: Wed, 6 Nov 2013 18:07:58 +0100 Message-ID: <20131106170758.GM14082@phenom.ffwll.local> References: <1383684151-595-1-git-send-email-ville.syrjala@linux.intel.com> <1383684151-595-5-git-send-email-ville.syrjala@linux.intel.com> <20131105130337.234a0a3f@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 37ED3102264 for ; Wed, 6 Nov 2013 09:07:30 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id e52so2647962eek.8 for ; Wed, 06 Nov 2013 09:07:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131105130337.234a0a3f@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 05, 2013 at 01:03:37PM -0800, Jesse Barnes wrote: > I don't think we want to add this; even though it's a small amount of > code it's totally unnecessary on real hw, and will probably just bit > rot. Wholeheartedly agreed. Stuff that isn't used bitrots and then confuses because "this can't possibly work ... oh, unused." Sometimes the dot encompass a few months though. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch