From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: Wrap the preallocated BIOS
 framebuffer and preserve for KMS fbcon v4
Date: Thu, 7 Nov 2013 08:28:01 -0800
Message-ID: <20131107082801.73cbceeb@jbarnes-desktop>
References: <1383764564-854-1-git-send-email-jbarnes@virtuousgeek.org>
	<1383765955-922-1-git-send-email-jbarnes@virtuousgeek.org>
	<20131107142255.GV15018@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from oproxy13-pub.mail.unifiedlayer.com
	(oproxy13-pub.mail.unifiedlayer.com [69.89.16.30])
	by gabe.freedesktop.org (Postfix) with SMTP id 4AD2DFBB8D
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  7 Nov 2013 08:27:15 -0800 (PST)
In-Reply-To: <20131107142255.GV15018@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 7 Nov 2013 14:22:55 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, Nov 06, 2013 at 11:25:55AM -0800, Jesse Barnes wrote:
> > Retrieve current framebuffer config info from the regs and create an fb
> > object for the buffer the BIOS or boot loader left us.  This should
> > allow for smooth transitions to userspace apps once we finish the
> > initial configuration construction.
> > 
> > v2: check for non-native modes and adjust (Jesse)
> >     fixup aperture and cmap frees (Imre)
> >     use unlocked unref if init_bios fails (Jesse)
> >     fix curly brace around DSPADDR check (Imre)
> >     comment failure path for pin_and_fence (Imre)
> > v3: fixup fixup of aperture frees (Chris)
> > v4: update to current bits (locking & pin_and_fence hack) (Jesse)
> 
> The only thing that I noticed was that the bookkeeping for the fb/obj is
> incorrect - which is presumably the hack mentioned above.

Yeah I should have left the pin_and_fence in with an #if 0 to make that
clearer... is that the only thing that's missing?

Any thoughts on why the pin_and_fence falls over on the preallocated
object?

-- 
Jesse Barnes, Intel Open Source Technology Center