From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: Use clamp_t() when limiting
 cur_delay
Date: Thu, 7 Nov 2013 20:05:19 +0100
Message-ID: <20131107190519.GY14082@phenom.ffwll.local>
References: <1383847069-3554-1-git-send-email-ville.syrjala@linux.intel.com>
	<1383847069-3554-2-git-send-email-ville.syrjala@linux.intel.com>
	<20131107105652.5686d50f@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com
	[209.85.215.173])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0CBA8112FC7
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  7 Nov 2013 11:04:51 -0800 (PST)
Received: by mail-ea0-f173.google.com with SMTP id g10so557595eak.4
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 07 Nov 2013 11:04:49 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131107105652.5686d50f@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Nov 07, 2013 at 10:56:52AM -0800, Jesse Barnes wrote:
> On Thu,  7 Nov 2013 19:57:49 +0200
> ville.syrjala@linux.intel.com wrote:
> =

> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Make the cur_delay limiting code a bit less prone to typo errors
> > by using clamp_t().
> > =

> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_irq.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > =

> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i91=
5_irq.c
> > index 54338cf..b940ebe 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -966,10 +966,8 @@ static void gen6_pm_rps_work(struct work_struct *w=
ork)
> >  	/* sysfs frequency interfaces may have snuck in while servicing the
> >  	 * interrupt
> >  	 */
> > -	if (new_delay < (int)dev_priv->rps.min_delay)
> > -		new_delay =3D dev_priv->rps.min_delay;
> > -	if (new_delay > (int)dev_priv->rps.max_delay)
> > -		new_delay =3D dev_priv->rps.max_delay;
> > +	new_delay =3D clamp_t(int, new_delay,
> > +			    dev_priv->rps.min_delay, dev_priv->rps.max_delay);
> >  	dev_priv->rps.last_adj =3D new_delay - dev_priv->rps.cur_delay;
> >  =

> >  	if (IS_VALLEYVIEW(dev_priv->dev))
> =

> What a nice little helper.

Indeed.
> =

> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Both patches merged to dinq, thanks.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch