From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v3 2/2] drm/i915/vlv: Rename VLV DPIO
 register to be more structure to match configdb document.
Date: Fri, 8 Nov 2013 17:42:18 +0100
Message-ID: <20131108164218.GD14082@phenom.ffwll.local>
References: <1383102678-7150-2-git-send-email-chon.ming.lee@intel.com>
	<1383792210-4768-1-git-send-email-chon.ming.lee@intel.com>
	<20131108092517.GA5986@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44])
	by gabe.freedesktop.org (Postfix) with ESMTP id 17154F9CA0
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  8 Nov 2013 12:48:03 -0800 (PST)
Received: by mail-ee0-f44.google.com with SMTP id d41so1270503eek.3
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 08 Nov 2013 12:48:03 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131108092517.GA5986@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Nov 08, 2013 at 11:25:17AM +0200, Ville Syrj=E4l=E4 wrote:
> On Thu, Nov 07, 2013 at 10:43:30AM +0800, Chon Ming Lee wrote:
> > Some VLV PHY/PLL DPIO registers have group/lane/channel access.  Current
> > DPIO register definition doesn't have a structure way to break them
> > down. As a result it is not easy to match the PHY/PLL registers with the
> > configdb document.  Rename those registers based on the configdb for ea=
sy
> > cross references, and without the need to check the offset in the header
> > file.
> > =

> > New format is as following.
> > =

> > <platform name>_<DPIO component><optional lane #>_DW<dword # in the
> > doc>_<optional channel #>
> > =

> > For example,
> > =

> > VLV_PCS_DW0 - Group access to PCS for lane 0 to 3 for PCS DWORD 0.
> > VLV_PCS01_DW0_CH0 - PCS access to lane 0/1, channel 0 for PCS DWORD 0.
> > =

> > Another example is
> > =

> > VLV_TX_DW0 - Group access to TX lane 0 to 3 for TX DWORD 0
> > VLV_TX0_DW0 - Refer to TX Lane 0 access only for TX DWORD 0.
> > =

> > There is no functional change on this patch.
> > =

> > v2: Rebase based on previous patch change.
> > v3: There may be configdb different version that document the start DW
> > differently. Add a comment to clarify.  Fix up some mismatch start DW
> > for second PLL block. (Ville)
> > =

> > Suggested-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com>
> =

> Yeah looks good to me.
> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch