From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Make AGP support optional Date: Fri, 8 Nov 2013 18:37:55 +0100 Message-ID: <20131108173755.GE14082@phenom.ffwll.local> References: <1383652808-25752-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1383652808-25752-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 05, 2013 at 02:00:08PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > We only depend on the intel-gtt module for GTT frobbign on older gens. > The intel_agp module is optional, except for UMS and some old XvMC > userland on gen3. So make AGP support optional. As before, we will > fail the i915 init for UMS and gen3 KMS the same as before if > intel_agp isn't around. > = > intel-gtt.c is left with a somewhat ugly ifdef mess, but I'm going > to save that for a later cleaning. > = > At least my gen2 still works with the patch and CONFIG_AGP=3Dn. > = > v2: Make i915 depend on X86 and PCI, and intel-gtt depend on PCI > = > Signed-off-by: Ville Syrj=E4l=E4 Every nail in the fake agp coffin is a good one. Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch