From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 14/21] drm/i915: Abstract backlight registers a bit Date: Fri, 8 Nov 2013 20:04:27 +0100 Message-ID: <20131108190427.GG14082@phenom.ffwll.local> References: <1383889251-498-1-git-send-email-benjamin.widawsky@intel.com> <1383889251-498-14-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 6016AFC0EE for ; Fri, 8 Nov 2013 12:43:59 -0800 (PST) Received: by mail-ee0-f47.google.com with SMTP id c13so1264179eek.34 for ; Fri, 08 Nov 2013 12:43:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <1383889251-498-14-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 07, 2013 at 09:40:44PM -0800, Ben Widawsky wrote: > Many GENs generally perform the same actions just on different > registers. This is true going forward as well. To ease the transition a > bit, extract the common code where possible. > > Signed-off-by: Ben Widawsky As explained on internal irc I'm rather reluctant to pull in refactoring patches into -fixes just for bdw enabling. Especially for fragile code like the backlight. So I'd just go with adding a copy-pasted version of set/get/enable for broadwell. That should also fit in with Jani's plans for 3.14 with the complete backlight refactoring. Adding Jani so he can explain what he'd like. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch