From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] lib/drmtest: Retire requests via drop caches after gem_quiescent_gpu Date: Sun, 10 Nov 2013 16:30:12 -0800 Message-ID: <20131111003009.GA15245@bwidawsk.net> References: <1383660919-4186-1-git-send-email-oscar.mateo@intel.com> <20131105183516.GE1775@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 139B7FA62C for ; Sun, 10 Nov 2013 22:27:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131105183516.GE1775@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 05, 2013 at 07:35:16PM +0100, Daniel Vetter wrote: > On Tue, Nov 05, 2013 at 02:15:19PM +0000, oscar.mateo@intel.com wrote: > > From: Oscar Mateo > > > > This helps make sure that the GPU is really quiescent by getting > > rid of any residual stuff. > > > > Signed-off-by: Oscar Mateo > > Merged, thanks for the patch. > -Daniel I'm hitting what seems to be a race on gem_suspend. Please fix. Subtest debugfs-reader: SUCCESS Test assertion failure function igt_drop_caches_set, file igt_debugfs.c:336: > > > --- > > lib/drmtest.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/drmtest.c b/lib/drmtest.c > > index e3fc166..d8fc60f 100644 > > --- a/lib/drmtest.c > > +++ b/lib/drmtest.c > > @@ -47,6 +47,7 @@ > > #include "i915_drm.h" > > #include "intel_chipset.h" > > #include "intel_gpu_tools.h" > > +#include "igt_debugfs.h" > > > > /* This file contains a bunch of wrapper functions to directly use gem ioctls. > > * Mostly useful to write kernel tests. */ > > @@ -163,6 +164,7 @@ void gem_quiescent_gpu(int fd) > > } > > > > gem_sync(fd, handle); > > + igt_drop_caches_set(DROP_RETIRE); > > } > > > > /** > > -- > > 1.7.9.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center