From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: tune down hangcheck noise
Date: Mon, 11 Nov 2013 08:02:27 +0100
Message-ID: <20131111070226.GL14082@phenom.ffwll.local>
References: <1377680382-20994-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com
	[209.85.215.179])
	by gabe.freedesktop.org (Postfix) with ESMTP id 154A8FA6D9
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 10 Nov 2013 23:01:56 -0800 (PST)
Received: by mail-ea0-f179.google.com with SMTP id r15so456329ead.38
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 10 Nov 2013 23:01:56 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1377680382-20994-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Aug 28, 2013 at 10:59:42AM +0200, Daniel Vetter wrote:
> We already have a big splashing *ERROR* for all the relevant cases of
> hangs, so this one here is redudant. And it results in an unclean
> dmesg when running with simulated hangs. Regression has been
> introduced in
> 
> commit 05407ff889ceebe383aa5907219f86582ef96b72
> Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Date:   Thu May 30 09:04:29 2013 +0300
> 
>     drm/i915: detect hang using per ring hangcheck_score
> 
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68641
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Tested-by: lu hua <huax.lu@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index a03b445..4c6853f 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2027,9 +2027,9 @@ static void i915_hangcheck_elapsed(unsigned long data)
>  
>  	for_each_ring(ring, dev_priv, i) {
>  		if (ring->hangcheck.score > FIRE) {
> -			DRM_ERROR("%s on %s\n",
> -				  stuck[i] ? "stuck" : "no progress",
> -				  ring->name);
> +			DRM_INFO("%s on %s\n",
> +				 stuck[i] ? "stuck" : "no progress",
> +				 ring->name);
>  			rings_hung++;
>  		}
>  	}
> -- 
> 1.8.4.rc3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch