From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915/vlv: Make the vlv_dpio_read/vlv_dpio_write more PHY centric Date: Mon, 11 Nov 2013 10:23:24 +0100 Message-ID: <20131111092324.GM14082@phenom.ffwll.local> References: <1383102678-7150-1-git-send-email-chon.ming.lee@intel.com> <1383719795-28431-1-git-send-email-chon.ming.lee@intel.com> <20131106105105.GD5986@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CE6FFACBC for ; Mon, 11 Nov 2013 01:22:53 -0800 (PST) Received: by mail-ee0-f44.google.com with SMTP id d51so182208eek.31 for ; Mon, 11 Nov 2013 01:22:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131106105105.GD5986@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 06, 2013 at 12:51:05PM +0200, Ville Syrj=E4l=E4 wrote: > On Wed, Nov 06, 2013 at 02:36:35PM +0800, Chon Ming Lee wrote: > > vlv_dpio_read/write should be describe more in PHY centric instead of > > display controller centric. > > Create a enum dpio_channel for channel index and enum dpio_phy for PHY > > index. This should better to gather for upcoming platform. > > = > > v2: Rebase the code based on > > drm/i915/vlv: Fix typo in the DPIO register define. > > = > > v3: Rename vlv_phy to dpio_phy_iosf_port and define additional macro > > DPIO_PHY, and remove unrelated change. (Ville) > > = > > Suggested-by: Ville Syrj=E4l=E4 > > Signed-off-by: Chon Ming Lee > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch