From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 5/5] drm/i915: don't memset the fb buffer Date: Wed, 13 Nov 2013 14:05:26 -0800 Message-ID: <20131113140526.02956fb5@jbarnes-desktop> References: <1384366848-845-1-git-send-email-jbarnes@virtuousgeek.org> <1384366848-845-6-git-send-email-jbarnes@virtuousgeek.org> <20131113215656.GA13207@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy4-pub.mail.unifiedlayer.com (oproxy4-pub.mail.unifiedlayer.com [74.220.216.66]) by gabe.freedesktop.org (Postfix) with SMTP id 60B70FAF2C for ; Wed, 13 Nov 2013 14:04:29 -0800 (PST) In-Reply-To: <20131113215656.GA13207@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 13 Nov 2013 21:56:56 +0000 Chris Wilson wrote: > On Wed, Nov 13, 2013 at 10:20:48AM -0800, Jesse Barnes wrote: > > It may be in use, let fbcon do it later if needed. > > Sadly we need to memset the stolen buffer in some circumstances, so we > need a bit more smarts. Upon resume and if !preallocated are the cases > that spring to mind. Maybe we can add a flag to ifbdev when we can skip > the clear? Yeah, we need something... clearing creates ugly artifacts in some cases that I'd like to avoid. -- Jesse Barnes, Intel Open Source Technology Center