From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/3] drm/i915: Make AGP=n work even on gen3
Date: Thu, 14 Nov 2013 01:24:57 +0200
Message-ID: <20131113232457.GM7819@intel.com>
References: <1384158919-30592-1-git-send-email-daniel.vetter@ffwll.ch>
	<1384158919-30592-2-git-send-email-daniel.vetter@ffwll.ch>
	<20131113185956.GF7819@intel.com>
	<20131113202144.GI7251@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20131113202144.GI7251@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Nov 13, 2013 at 09:21:44PM +0100, Daniel Vetter wrote:
> On Wed, Nov 13, 2013 at 08:59:56PM +0200, Ville Syrj=E4l=E4 wrote:
> > On Mon, Nov 11, 2013 at 09:35:17AM +0100, Daniel Vetter wrote:
> > > Most platforms din't hit this condition, but if we want to allow
> > > building without agp we should also make this allowed on gen3.
> > > =

> > > Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > ---
> > >  drivers/gpu/drm/i915/i915_drv.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > =

> > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i=
915_drv.c
> > > index 38a344694e35..d7c922051c89 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.c
> > > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > > @@ -158,7 +158,7 @@ static struct drm_driver driver;
> > >  #if IS_ENABLED(CONFIG_AGP_INTEL)
> > >  extern int intel_agp_enabled;
> > >  #else
> > > -static int intel_agp_enabled;
> > > +static int intel_agp_enabled =3D 1;
> > =

> > Patch 2/3 eliminates our only use of intel_agp_enabled, so this patch
> > seems pointless.
> =

> Patch 2 has a good chance to get reverted, so having this separate isn't
> completely pointless. Should have mentioned this in the cover letter ;-)

OK, makes sense.

Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

-- =

Ville Syrj=E4l=E4
Intel OTC