From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 3/5] drm/i915: retrieve current fb config into new plane_config structure at init v2 Date: Fri, 15 Nov 2013 10:11:04 -0800 Message-ID: <20131115101104.532859b4@jbarnes-desktop> References: <1384473865-1456-1-git-send-email-jbarnes@virtuousgeek.org> <1384473865-1456-3-git-send-email-jbarnes@virtuousgeek.org> <20131114164421.27bf665e@bpaauwe-desk.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9-pub.mail.unifiedlayer.com (oproxy9-pub.mail.unifiedlayer.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 235C7105A11 for ; Fri, 15 Nov 2013 10:10:05 -0800 (PST) In-Reply-To: <20131114164421.27bf665e@bpaauwe-desk.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Bob Paauwe Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 14 Nov 2013 16:44:21 -0800 Bob Paauwe wrote: > > +struct intel_plane_config { > > + int pixel_format; /* DRM fourcc code */ > > Comment isn't right unless I'm missing something. Looks like this pixel > format is set to the intel pixel format values, not the DRM fourcc > values. > Stale comment, I changed my mind on what to store here. Thanks for catching it. -- Jesse Barnes, Intel Open Source Technology Center