From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 10/23] piglit: Run our test suite with
 --no-concurrency
Date: Fri, 15 Nov 2013 18:08:27 +0100
Message-ID: <20131115170827.GV22741@phenom.ffwll.local>
References: <1384533220-20780-1-git-send-email-damien.lespiau@intel.com>
	<1384533220-20780-11-git-send-email-damien.lespiau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id E6D4C1058DB
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 15 Nov 2013 09:07:54 -0800 (PST)
Received: by mail-ea0-f177.google.com with SMTP id f15so1379725eak.36
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 15 Nov 2013 09:07:52 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1384533220-20780-11-git-send-email-damien.lespiau@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Nov 15, 2013 at 04:33:27PM +0000, Damien Lespiau wrote:
> Tests tend to assume they are the only thing running, some need DRM
> master, some fill the memory. All in all, they are some correctness
> issues if we run tests concurrently.
> 
> Acked-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Concurrency is a per-test opt-in thing in piglit. So this is cargo-cult
and worse will prevent us to run a subset of tests to run in parallel
(e.g. once we have a naming scheme for abi stuff).
-Daniel

> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 5742b82..f280879 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -50,7 +50,7 @@ dist-hook: ChangeLog INSTALL
>  #
>  # Useful shortcuts to run tests
>  #
> -PIGLIT := $(srcdir)/piglit/piglit-run.py
> +PIGLIT := $(srcdir)/piglit/piglit-run.py --no-concurrency
>  PIGLIT_SUMMARY := $(srcdir)/piglit/piglit-summary.py -s
>  PIGLIT_HTML := $(srcdir)/piglit/piglit-summary-html.py
>  IGT_TESTS := $(abs_srcdir)/piglit/tests/igt.tests
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch