From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 16/23] drm_lib.sh: Tune the DRM master message a bit Date: Fri, 15 Nov 2013 18:13:48 +0100 Message-ID: <20131115171348.GW22741@phenom.ffwll.local> References: <1384533220-20780-1-git-send-email-damien.lespiau@intel.com> <1384533220-20780-17-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BE601059EC for ; Fri, 15 Nov 2013 09:13:14 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id e53so1226977eek.28 for ; Fri, 15 Nov 2013 09:13:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1384533220-20780-17-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 15, 2013 at 04:33:33PM +0000, Damien Lespiau wrote: > check_drm_clients can be used to make sure there's no master running. > Tune a bit the error message as this is really what we want to test. > > Signed-off-by: Damien Lespiau > --- > tests/drm_lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh > index 97f6f92..92b379f 100755 > --- a/tests/drm_lib.sh > +++ b/tests/drm_lib.sh > @@ -31,7 +31,7 @@ fi > # read everything we can > if [ `cat $i915_dfs_path/clients | wc -l` -gt "2" ] ; then > [ -n "$DRM_LIB_ALLOW_NO_MASTER" ] || \ > - die "ERROR: other drm clients running" > + die "ERROR: a drm master is already running" Imo the current line is clear enough and we do actually check for any drm client, not just master ... But I don't really care. -Daniel > fi > > i915_sfs_path= > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch