From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 10/23] piglit: Run our test suite with --no-concurrency Date: Fri, 15 Nov 2013 17:17:06 +0000 Message-ID: <20131115171706.GG14757@strange.amr.corp.intel.com> References: <1384533220-20780-1-git-send-email-damien.lespiau@intel.com> <1384533220-20780-11-git-send-email-damien.lespiau@intel.com> <20131115170827.GV22741@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 37E1D1059BA for ; Fri, 15 Nov 2013 09:17:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131115170827.GV22741@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 15, 2013 at 06:08:27PM +0100, Daniel Vetter wrote: > On Fri, Nov 15, 2013 at 04:33:27PM +0000, Damien Lespiau wrote: > > Tests tend to assume they are the only thing running, some need DRM > > master, some fill the memory. All in all, they are some correctness > > issues if we run tests concurrently. > > > > Acked-by: Ben Widawsky > > Signed-off-by: Damien Lespiau > > Concurrency is a per-test opt-in thing in piglit. So this is cargo-cult > and worse will prevent us to run a subset of tests to run in parallel > (e.g. once we have a naming scheme for abi stuff). Right now, the concurrency runs have big problems. Running anything along drv_module_reload will fail to open the device (and as it fails quickly, a lot of tests will end up being "skipped" (instead of failing, which is another bug)). Hence using --no-concurrency for now. It's something we can maintain in tree though, and remove once we are more confident it has a reasonable chance to work. -- Damien