From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: More questions and patches for 835GM/ns2501 DVO Date: Fri, 15 Nov 2013 18:33:00 +0100 Message-ID: <20131115173300.GZ22741@phenom.ffwll.local> References: <52768009.7070905@math.tu-berlin.de> <20131103171208.GA4167@phenom.ffwll.local> <19544_1383498802_52768431_19544_2610_1_20131103171348.GB4167@phenom.ffwll.local> <52769D39.5070501@math.tu-berlin.de> <20131103211814.GC4167@phenom.ffwll.local> <20131106103405.GH14082@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id B5D11FB6E8 for ; Fri, 15 Nov 2013 09:32:26 -0800 (PST) Received: by mail-ee0-f41.google.com with SMTP id e53so1238203eek.28 for ; Fri, 15 Nov 2013 09:32:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131106103405.GH14082@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Thomas Richter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 06, 2013 at 11:34:05AM +0100, Daniel Vetter wrote: > On Sun, Nov 03, 2013 at 10:18:14PM +0100, Daniel Vetter wrote: > > Hm, that would mean that the cursor is somehow stuck in the enabled state, > > despite that we've tried to disabled it very hard. Can you please try out > > the below patch? If this doesn't work please take not of the different > > WARNINGs you're hitting and whether it's always the same one with the same > > calltrace or something different. > > > > I think for now we should try to get the single monitor case working - I > > have a few theories for the dual-screen issues, but there's not much point > > working on them if the simple case doesn't work yet. > > > > Also I think I'll merge the two patches if they don't make things worse > > for you, imo it's the right approach and at least conceptually should be > > able to avoid all these retry loops. > > > > Thanks, Daniel > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > > index f34252d134b6..04d2699f51b4 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -7123,7 +7123,9 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 base) > > intel_crtc->cursor_visible = visible; > > } > > /* and commit changes on next vblank */ > > + POSTING_READ(CURCNTR(pipe)); > > I915_WRITE(CURBASE(pipe), base); > > + POSTING_READ(CURBASE(pipe)); > > } > > > > static void ivb_update_cursor(struct drm_crtc *crtc, u32 base) > > @@ -7152,7 +7154,9 @@ static void ivb_update_cursor(struct drm_crtc *crtc, u32 base) > > intel_crtc->cursor_visible = visible; > > } > > /* and commit changes on next vblank */ > > + POSTING_READ(CURCNTR_IVB(pipe)); > > I915_WRITE(CURBASE_IVB(pipe), base); > > + POSTING_READ(CURBASE_IVB(pipe)); > > } > > To clarify: Do you need this patch to make the single-pipe mode work > reliably? It's a bit unclear in your answer ... To clarify my clarification question: Do you need the above quoted patch to make the cursor work better on your system? This is not about a WARN or the flicker or dual pipe (last time I've asked you kinda went on a tangent). I'm asking again since this patch for the cursor code is currently blocked from merging because I couldn't get a clear "this is needed, yes" from you. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch