From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915/vlv: Add VLV specific force wake
 routines.
Date: Tue, 19 Nov 2013 10:05:41 -0800
Message-ID: <20131119100541.5ece956a@jbarnes-desktop>
References: <1384435935-13571-1-git-send-email-deepak.s@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from oproxy16-pub.mail.unifiedlayer.com
	(oproxy16-pub.mail.unifiedlayer.com [69.89.22.201])
	by gabe.freedesktop.org (Postfix) with SMTP id 59504FC077
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 19 Nov 2013 10:04:35 -0800 (PST)
In-Reply-To: <1384435935-13571-1-git-send-email-deepak.s@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: deepak.s@intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 14 Nov 2013 19:02:15 +0530
deepak.s@intel.com wrote:

> From: Deepak S <deepak.s@intel.com>
> 
> Added media/render/common well VLV force wake routines to help
> bring up the WELLS before access the register
> - Refactor current vlv_forcewake get/put and added MEDIA or
>   RENDER specific Forcewake.
> - Added VLV Check to bring up MEDIA and RENDER WELL base
>   on the register accessed in vlv_read##x (in intel_uncore.c)

This patch is pretty big and so a bit hard to review.  A couple of
questions:
  - why not use the callback to __vlv_force_wake_* from
    gen6_gt_force_wake_*?  i.e. why is VLV special here?
  - having a new gen7_media_force_wake function may be better than
    passing an engine around, and would touch fewer pieces of code
  - have you done measurements on this?  given how infrequently we
    ought to be waking the wells when they're idle, and how long we
    generally keep them awake, is this a real power win?

Thanks,
Jesse