From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] intel: make sure VG_CLEAR() will always do memory clear Date: Wed, 20 Nov 2013 11:36:20 +0000 Message-ID: <20131120113620.GA32765@strange.amr.corp.intel.com> References: <1384939368-17291-1-git-send-email-zhenyuw@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 0329D106785 for ; Wed, 20 Nov 2013 03:36:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <1384939368-17291-1-git-send-email-zhenyuw@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 20, 2013 at 05:22:48PM +0800, Zhenyu Wang wrote: > If valgrind is not available, current VG_CLEAR() would just ignore > memory clear operation which might make invalid ioctl argument. So > make sure VG_CLEAR() will always clear memory. > --- > intel/intel_bufmgr_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c > index df6fcec..389f73a 100644 > --- a/intel/intel_bufmgr_gem.c > +++ b/intel/intel_bufmgr_gem.c > @@ -74,7 +74,7 @@ > #define VG(x) > #endif > > -#define VG_CLEAR(s) VG(memset(&s, 0, sizeof(s))) > +#define VG_CLEAR(s) (memset(&s, 0, sizeof(s))) VG_CLEAR() is really just for valgrind. If you need to set some specific variable/field to 0 then you need to set it to 0 and not rely on VG_CLEAR() to do it for you. What's the actual issue you have? -- Damien