From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Fix gen3 self-refresh watermarks
Date: Wed, 20 Nov 2013 15:53:19 +0100
Message-ID: <20131120145319.GC27344@phenom.ffwll.local>
References: <1384956130-5661-1-git-send-email-daniel.vetter@ffwll.ch>
	<20131120144714.GB7819@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51])
	by gabe.freedesktop.org (Postfix) with ESMTP id B6FECFD3EF
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 20 Nov 2013 06:52:44 -0800 (PST)
Received: by mail-ee0-f51.google.com with SMTP id d41so3354997eek.24
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 20 Nov 2013 06:52:44 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131120144714.GB7819@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Nov 20, 2013 at 04:47:14PM +0200, Ville Syrj=E4l=E4 wrote:
> On Wed, Nov 20, 2013 at 03:02:10PM +0100, Daniel Vetter wrote:
> > This regression has been introduced in
> > =

> > commit 4fe8590a921d0b2e36e542dbfa89a8c5993f5a3f
> > Author: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Date:   Wed Sep 4 18:25:22 2013 +0300
> > =

> >     drm/i915: Use adjusted_mode appropriately when computing watermarks
> > =

> > I guess we should renable the enabled local variable into something a
> > notch more descriptive, but that's something for -next.
> > =

> > The effect on my i945gme netbook is pretty severe amounts of underruns
> > - usually the very first pixel gets used for the entire screeen.
> > =

> > Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> =

> Dang. Copy paste fail on my part :( The fix looks good.
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the review.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch