From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 07/10] drm/i915: Kill sandybridge_blit_fbc_update() Date: Wed, 20 Nov 2013 14:56:44 -0800 Message-ID: <20131120225644.GE4234@bratislava.jf.intel.com> References: <1383771745-22463-1-git-send-email-ville.syrjala@linux.intel.com> <1383771745-22463-8-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 71E2FFB6DA for ; Wed, 20 Nov 2013 14:56:48 -0800 (PST) Received: by mail-pd0-f181.google.com with SMTP id p10so2621050pdj.26 for ; Wed, 20 Nov 2013 14:56:48 -0800 (PST) Content-Disposition: inline In-Reply-To: <1383771745-22463-8-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 06, 2013 at 11:02:22PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > No longer needed since the LRIs do the work. Shouldn't this be part of previous patch? > = > v2: Rebased due to hunk getting dropped from an ealier patch > = > Signed-off-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_pm.c | 23 ----------------------- > 1 file changed, 23 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index dc65bb4..3f600ba 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -187,26 +187,6 @@ static bool g4x_fbc_enabled(struct drm_device *dev) > return I915_READ(DPFC_CONTROL) & DPFC_CTL_EN; > } > = > -static void sandybridge_blit_fbc_update(struct drm_device *dev) > -{ > - struct drm_i915_private *dev_priv =3D dev->dev_private; > - u32 blt_ecoskpd; > - > - /* Make sure blitter notifies FBC of writes */ > - gen6_gt_force_wake_get(dev_priv); > - blt_ecoskpd =3D I915_READ(GEN6_BLITTER_ECOSKPD); > - blt_ecoskpd |=3D GEN6_BLITTER_FBC_NOTIFY << > - GEN6_BLITTER_LOCK_SHIFT; > - I915_WRITE(GEN6_BLITTER_ECOSKPD, blt_ecoskpd); > - blt_ecoskpd |=3D GEN6_BLITTER_FBC_NOTIFY; > - I915_WRITE(GEN6_BLITTER_ECOSKPD, blt_ecoskpd); > - blt_ecoskpd &=3D ~(GEN6_BLITTER_FBC_NOTIFY << > - GEN6_BLITTER_LOCK_SHIFT); > - I915_WRITE(GEN6_BLITTER_ECOSKPD, blt_ecoskpd); > - POSTING_READ(GEN6_BLITTER_ECOSKPD); > - gen6_gt_force_wake_put(dev_priv); > -} > - > static void ironlake_enable_fbc(struct drm_crtc *crtc, > struct drm_framebuffer *fb, > unsigned long interval) > @@ -240,7 +220,6 @@ static void ironlake_enable_fbc(struct drm_crtc *crtc, > I915_WRITE(SNB_DPFC_CTL_SA, > SNB_CPU_FENCE_ENABLE | obj->fence_reg); > I915_WRITE(DPFC_CPU_FENCE_OFFSET, crtc->y); > - sandybridge_blit_fbc_update(dev); > } > = > DRM_DEBUG_KMS("enabled fbc on plane %c\n", plane_name(intel_crtc->plane= )); > @@ -297,8 +276,6 @@ static void gen7_enable_fbc(struct drm_crtc *crtc, > SNB_CPU_FENCE_ENABLE | obj->fence_reg); > I915_WRITE(DPFC_CPU_FENCE_OFFSET, crtc->y); > = > - sandybridge_blit_fbc_update(dev); > - > DRM_DEBUG_KMS("enabled fbc on plane %d\n", intel_crtc->plane); > } > = > -- = > 1.8.1.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx