From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 10/10] drm/i915: Use plane_name() in gen7_enable_fbc() Date: Thu, 21 Nov 2013 09:08:44 +0100 Message-ID: <20131121080844.GG27344@phenom.ffwll.local> References: <1383771745-22463-1-git-send-email-ville.syrjala@linux.intel.com> <1383771745-22463-11-git-send-email-ville.syrjala@linux.intel.com> <20131120230103.GH4234@bratislava.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id F195DFCEB0 for ; Thu, 21 Nov 2013 00:08:06 -0800 (PST) Received: by mail-ea0-f182.google.com with SMTP id o10so5437565eaj.41 for ; Thu, 21 Nov 2013 00:08:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131120230103.GH4234@bratislava.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Nov 20, 2013 at 03:01:03PM -0800, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > = > On Wed, Nov 06, 2013 at 11:02:25PM +0200, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > All the other .enable_fbc() funcs use plane_name(). Make > > gen7_enable_fbc() do the same. > > = > > Signed-off-by: Ville Syrj=E4l=E4 I've picked up a few of the reviewed patches here. Overall we still have the issue that enabling the fbc tracking totally wreaks havoc with the blitter performance on gen6+ ... I still think the way to fix that is to do s/w based tracking and forgo all the neat hw support. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch