From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 10/10] drm/i915: Use plane_name() in
 gen7_enable_fbc()
Date: Thu, 21 Nov 2013 12:55:18 +0200
Message-ID: <20131121105518.GF7819@intel.com>
References: <1383771745-22463-1-git-send-email-ville.syrjala@linux.intel.com>
	<1383771745-22463-11-git-send-email-ville.syrjala@linux.intel.com>
	<20131120230103.GH4234@bratislava.jf.intel.com>
	<20131121080844.GG27344@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9F2DAFB88B
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 21 Nov 2013 02:55:22 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131121080844.GG27344@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Nov 21, 2013 at 09:08:44AM +0100, Daniel Vetter wrote:
> On Wed, Nov 20, 2013 at 03:01:03PM -0800, Rodrigo Vivi wrote:
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> > =

> > On Wed, Nov 06, 2013 at 11:02:25PM +0200, ville.syrjala@linux.intel.com=
 wrote:
> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > =

> > > All the other .enable_fbc() funcs use plane_name(). Make
> > > gen7_enable_fbc() do the same.
> > > =

> > > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> I've picked up a few of the reviewed patches here. Overall we still have
> the issue that enabling the fbc tracking totally wreaks havoc with the
> blitter performance on gen6+ ... I still think the way to fix that is to
> do s/w based tracking and forgo all the neat hw support.

Maybe we can do both. The tracking code is not that intrusive IMO, so
giving the user a choice would make it easier to figure out if there
is a performance vs. power tradeoff between hardware and software
tracking.

-- =

Ville Syrj=E4l=E4
Intel OTC