From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 8/9] drm/i915: Hook up dirtyfb ioctl for FBC
 nuke
Date: Fri, 22 Nov 2013 17:19:01 +0200
Message-ID: <20131122151901.GE10036@intel.com>
References: <1385062193-19466-1-git-send-email-ville.syrjala@linux.intel.com>
	<1385062193-19466-9-git-send-email-ville.syrjala@linux.intel.com>
	<20131121231802.GA4166@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6F31BFAB29
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 22 Nov 2013 07:19:06 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131121231802.GA4166@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Nov 21, 2013 at 11:18:02PM +0000, Chris Wilson wrote:
> On Thu, Nov 21, 2013 at 09:29:52PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > FBC host modification tracking only works through GTT mmaps, so any
> > direct CPU access needs to manually nuke the compressed framebuffer
> > on modifications. Hook up the dirtyfb ioctl to do just that.
> =

> But direct CPU access (not GTT) notification is done through SW_FINISH
> ioctl. Overzealously nuking FBC here makes it inconvenient for userpsace
> to use fb_dirty as part of its periodic-flush-scanout procedure.

I see. I can move the fbc nuke to sw_finish. Could we actually document
the rules for these ioctls somewhere?

-- =

Ville Syrj=E4l=E4
Intel OTC