From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/3] drm/i915: Add power well arguments to
 force wake routines.
Date: Mon, 25 Nov 2013 08:29:37 -0800
Message-ID: <20131125082937.6777dff6@jbarnes-desktop>
References: <1385198744-9333-1-git-send-email-deepak.s@intel.com>
	<1385198744-9333-2-git-send-email-deepak.s@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from alt-proxy1.mail.unifiedlayer.com (unknown [70.40.203.67])
	by gabe.freedesktop.org (Postfix) with SMTP id 12535FB24C
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 27 Nov 2013 18:09:36 -0800 (PST)
In-Reply-To: <1385198744-9333-2-git-send-email-deepak.s@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: deepak.s@intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, 23 Nov 2013 14:55:42 +0530
deepak.s@intel.com wrote:

> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4840,8 +4840,8 @@
>  #define  EDP_LINK_TRAIN_VOL_EMP_MASK_IVB	(0x3f<<22)
>  
>  #define  FORCEWAKE				0xA18C
> -#define  FORCEWAKE_VLV				0x1300b0
> -#define  FORCEWAKE_ACK_VLV			0x1300b4
> +#define  FORCEWAKE_VLV			0x1300b0
> +#define  FORCEWAKE_ACK_VLV		0x1300b4
>  #define  FORCEWAKE_MEDIA_VLV			0x1300b8
>  #define  FORCEWAKE_ACK_MEDIA_VLV		0x1300bc
>  #define  FORCEWAKE_ACK_HSW			0x130044

This hunk is spurious, but doesn't really matter.  Maybe Daniel can
trim it out when he applies.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center