From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Fix module unloading with
 DRM_I915_UMS=n
Date: Mon, 25 Nov 2013 09:41:37 +0100
Message-ID: <20131125084137.GR27344@phenom.ffwll.local>
References: <20131115103451.GB22650@nuc-i3427.alporthouse.com>
	<1384532193-15780-1-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGQpmxfKay5eUt4VG6-LzJm7-55MS+ciB+GFhET=cKeajg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
	[74.125.82.181])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4D230FA6BA
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Nov 2013 00:40:57 -0800 (PST)
Received: by mail-we0-f181.google.com with SMTP id x55so3556380wes.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Nov 2013 00:40:57 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGQpmxfKay5eUt4VG6-LzJm7-55MS+ciB+GFhET=cKeajg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Nov 22, 2013 at 05:25:41PM -0200, Paulo Zanoni wrote:
> 2013/11/15 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Oops, makes testing early boot failures in i915.ko a bit more pain, so
> > let's fix it.
> >
> > v2: We already have a bit of static storage to track this (Chris).
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I can reproduce the failure by booting with i915.modeset=0, then get
> the oops when "rmmod i915".
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> I also looked at Chris' patch. I think that since we take the early
> "return 0" inside i915_init, we never call drm_pci_init, so it doesn't
> make too much sense to fix the problem inside drm_pci_exit.

Thanks for review&testing, patch merged.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch