From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] tests/igt: Add runtime environment checks
Date: Tue, 26 Nov 2013 19:53:33 +0000
Message-ID: <20131126195332.GC32421@strange.icx.intel.com>
References: <1385453344-25217-1-git-send-email-daniel.vetter@ffwll.ch>
	<20131126190556.GB27358@bwidawsk.net>
	<20131126194619.GS27344@phenom.ffwll.local>
	<20131126194942.GD27358@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20131126194942.GD27358@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: piglit discussion list <piglit@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Nov 26, 2013 at 11:49:43AM -0800, Ben Widawsky wrote:
> > Only in the make target he created, not in piglit itself. Imo we should
> > have all the testrunner logic in one place, i.e. in the piglit sources.
> > -Daniel
> 
> Damien, can you comment? I could have sworn you said something different
> on IRC. It sounded like exactly what I wanted.

What Daniel says is correct, the check is part of the runner wrapper,
not piglit itself.

I'd rather have a environement check up-front and I don't mind where it
lives (igt Vs piglit).

-- 
Damien