From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben-Egm8mFWDmf3k1uMJSBkQmQ@public.gmane.org>
Subject: Re: [PATCH] tests/igt: Add runtime environment checks
Date: Tue, 26 Nov 2013 12:02:39 -0800
Message-ID: <20131126200238.GE27358@bwidawsk.net>
References: <1385453344-25217-1-git-send-email-daniel.vetter@ffwll.ch>
	<20131126190556.GB27358@bwidawsk.net>
	<20131126194619.GS27344@phenom.ffwll.local>
	<20131126194942.GD27358@bwidawsk.net>
	<20131126195332.GC32421@strange.icx.intel.com>
	<CAKMK7uEeyNShA8fAF82+prCgYTVd2G60GLVMCCVy56p2uRGeJA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <piglit-bounces+gcvp-piglit=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <CAKMK7uEeyNShA8fAF82+prCgYTVd2G60GLVMCCVy56p2uRGeJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/piglit>,
	<mailto:piglit-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/piglit>
List-Post: <mailto:piglit-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:piglit-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/piglit>,
	<mailto:piglit-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Sender: piglit-bounces+gcvp-piglit=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Errors-To: piglit-bounces+gcvp-piglit=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
To: Daniel Vetter <daniel.vetter-/w4YWyX8dFk@public.gmane.org>
Cc: piglit discussion list <piglit-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Intel Graphics Development <intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Nov 26, 2013 at 08:55:40PM +0100, Daniel Vetter wrote:
> On Tue, Nov 26, 2013 at 8:53 PM, Damien Lespiau
> <damien.lespiau-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > On Tue, Nov 26, 2013 at 11:49:43AM -0800, Ben Widawsky wrote:
> >> > Only in the make target he created, not in piglit itself. Imo we should
> >> > have all the testrunner logic in one place, i.e. in the piglit sources.
> >> > -Daniel
> >>
> >> Damien, can you comment? I could have sworn you said something different
> >> on IRC. It sounded like exactly what I wanted.
> >
> > What Daniel says is correct, the check is part of the runner wrapper,
> > not piglit itself.
> >
> > I'd rather have a environement check up-front and I don't mind where it
> > lives (igt Vs piglit).
> 
> The problem is that generating the testlist (or printing the commands)
> is a feature QA actually relies on. I also use it occasionally to
> quickly test igt library changes. So we can't bail that early. My
> patch bails fairly late, but I didn't see a better spot.
> -Daniel

I'm confused then about how this really improves my current situation.

-- 
Ben Widawsky, Intel Open Source Technology Center