From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts Date: Wed, 27 Nov 2013 16:59:52 +0100 Message-ID: <20131127155951.GZ27344@phenom.ffwll.local> References: <1385198744-9333-1-git-send-email-deepak.s@intel.com> <1385198744-9333-4-git-send-email-deepak.s@intel.com> <20131125083835.5ccda77f@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by gabe.freedesktop.org (Postfix) with ESMTP id 948BAFA9BA for ; Wed, 27 Nov 2013 07:59:11 -0800 (PST) Received: by mail-ea0-f176.google.com with SMTP id h14so4879879eaj.21 for ; Wed, 27 Nov 2013 07:59:10 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: "S, Deepak" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 26, 2013 at 10:12:48AM +0000, S, Deepak wrote: > Yes Jesse, this is a warning fix. Yeah, those should be separate or at least mentioned in the commit message. But I have this one already so it naturally dropped out. All three patches merged to dinq, thanks. -Daniel > > -----Original Message----- > From: Jesse Barnes [mailto:jbarnes@virtuousgeek.org] > Sent: Monday, November 25, 2013 10:09 PM > To: S, Deepak > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Enabling DebugFS for valleyview forcewake counts > > On Sat, 23 Nov 2013 14:55:44 +0530 > deepak.s@intel.com wrote: > > @@ -2349,7 +2357,7 @@ static int pipe_crc_set_source(struct drm_device > > *dev, enum pipe pipe, { > > struct drm_i915_private *dev_priv = dev->dev_private; > > struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[pipe]; > > - u32 val; > > + u32 val = 0; > > int ret; > > > > if (pipe_crc->source == source) > > Spurious warning fix? Otherwise looks fine. > > Reviewed-by: Jesse Barnes > > -- > Jesse Barnes, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch