From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: Make the connector mode_valid() vfunc return a drm_mode_status enum Date: Thu, 28 Nov 2013 16:49:08 +0100 Message-ID: <20131128154908.GM27344@phenom.ffwll.local> References: <1385652558-7769-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com [209.85.215.178]) by gabe.freedesktop.org (Postfix) with ESMTP id C1B34FB73E for ; Thu, 28 Nov 2013 07:48:26 -0800 (PST) Received: by mail-ea0-f178.google.com with SMTP id d10so5944097eaj.37 for ; Thu, 28 Nov 2013 07:48:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <1385652558-7769-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 28, 2013 at 03:29:17PM +0000, Damien Lespiau wrote: > To make it clear what exactly mode_valid() should return. > > Signed-off-by: Damien Lespiau Reviewed-by: Daniel Vetter > --- > include/drm/drm_crtc_helper.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h > index ef6ad3a..b1388b5 100644 > --- a/include/drm/drm_crtc_helper.h > +++ b/include/drm/drm_crtc_helper.h > @@ -120,8 +120,8 @@ struct drm_encoder_helper_funcs { > */ > struct drm_connector_helper_funcs { > int (*get_modes)(struct drm_connector *connector); > - int (*mode_valid)(struct drm_connector *connector, > - struct drm_display_mode *mode); > + enum drm_mode_status (*mode_valid)(struct drm_connector *connector, > + struct drm_display_mode *mode); > struct drm_encoder *(*best_encoder)(struct drm_connector *connector); > }; > > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch