From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/19] drm/i915: use the correct force_wake function at the PC8 code Date: Fri, 29 Nov 2013 14:23:51 +0100 Message-ID: <20131129132351.GU27344@phenom.ffwll.local> References: <1385048853-1579-3-git-send-email-przanoni@gmail.com> <1385582240-2213-1-git-send-email-przanoni@gmail.com> <20131129111441.GB23993@bratislava.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com [209.85.215.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 61103FAB57 for ; Fri, 29 Nov 2013 05:23:08 -0800 (PST) Received: by mail-ea0-f174.google.com with SMTP id b10so6726917eae.33 for ; Fri, 29 Nov 2013 05:23:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131129111441.GB23993@bratislava.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 29, 2013 at 09:14:41AM -0200, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Wed, Nov 27, 2013 at 05:57:20PM -0200, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > When I submitted the first patch adding these force wake functions, > > Chris Wilson observed that I was using the wrong functions, so I sent > > a second version of the patch to correct this problem. The problem is > > that v1 was merged instead of v2. > > > > I was able to notice the problem when running the > > debugfs-forcewake-user subtest of pm_pc8 from intel-gpu-tools. > > > > V2: - Rebase on the FORCEWAKE_ALL change. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Paulo Zanoni Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch