From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix port name in vlv_wait_port_ready() timeout warning Date: Fri, 29 Nov 2013 15:03:11 +0100 Message-ID: <20131129140311.GZ27344@phenom.ffwll.local> References: <1385724109-30533-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com [209.85.215.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 61495FB1B8 for ; Fri, 29 Nov 2013 06:02:28 -0800 (PST) Received: by mail-ea0-f178.google.com with SMTP id d10so6764828eaj.23 for ; Fri, 29 Nov 2013 06:02:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <1385724109-30533-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 29, 2013 at 01:21:49PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > We're currently misprinting the port name when vlv_wait_port_ready() > times out. Fix it by using port_name(). > = > Signed-off-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 45a87d1..1534910 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1513,7 +1513,7 @@ void vlv_wait_port_ready(struct drm_i915_private *d= ev_priv, > = > if (wait_for((I915_READ(DPLL(0)) & port_mask) =3D=3D 0, 1000)) > WARN(1, "timed out waiting for port %c ready: 0x%08x\n", > - 'B' + dport->port, I915_READ(DPLL(0))); > + port_name(dport->port), I915_READ(DPLL(0))); > } > = > /** > -- = > 1.8.3.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch