From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms Date: Fri, 29 Nov 2013 15:10:17 +0100 Message-ID: <20131129141017.GA27344@phenom.ffwll.local> References: <1385652602-8528-1-git-send-email-ville.syrjala@linux.intel.com> <1385652602-8528-9-git-send-email-ville.syrjala@linux.intel.com> <20131129135619.GJ27806@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com [209.85.215.182]) by gabe.freedesktop.org (Postfix) with ESMTP id F2E2EFB049 for ; Fri, 29 Nov 2013 06:09:33 -0800 (PST) Received: by mail-ea0-f182.google.com with SMTP id o10so9132006eaj.41 for ; Fri, 29 Nov 2013 06:09:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131129135619.GJ27806@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 29, 2013 at 01:56:19PM +0000, Chris Wilson wrote: > On Thu, Nov 28, 2013 at 05:30:02PM +0200, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > All mobile gen2 and gen3 chipsets should have FBC1, and the code > > should now handle them all. So just set has_fbc=3Dtrue for all such > > chipsets. > = > Just comment here that the default value for i915_enable_fbc is still > off for gen2, so for the user to actually enable FBC requires opting-in. Can we please dare and just enable it? Imo going through all this trouble and not trying isn't really worth it ... -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch