From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 8/8] drm/i915: Enable FBC for all mobile gen2 and gen3 platforms Date: Fri, 29 Nov 2013 16:39:03 +0200 Message-ID: <20131129143903.GI10036@intel.com> References: <1385652602-8528-1-git-send-email-ville.syrjala@linux.intel.com> <1385652602-8528-9-git-send-email-ville.syrjala@linux.intel.com> <20131129135619.GJ27806@nuc-i3427.alporthouse.com> <20131129141017.GA27344@phenom.ffwll.local> <20131129141552.GO27806@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 396A9FA257 for ; Fri, 29 Nov 2013 06:39:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131129141552.GO27806@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Nov 29, 2013 at 02:15:52PM +0000, Chris Wilson wrote: > On Fri, Nov 29, 2013 at 03:10:17PM +0100, Daniel Vetter wrote: > > On Fri, Nov 29, 2013 at 01:56:19PM +0000, Chris Wilson wrote: > > > On Thu, Nov 28, 2013 at 05:30:02PM +0200, ville.syrjala@linux.intel.c= om wrote: > > > > From: Ville Syrj=E4l=E4 > > > > = > > > > All mobile gen2 and gen3 chipsets should have FBC1, and the code > > > > should now handle them all. So just set has_fbc=3Dtrue for all such > > > > chipsets. > > > = > > > Just comment here that the default value for i915_enable_fbc is still > > > off for gen2, so for the user to actually enable FBC requires opting-= in. > > = > > Can we please dare and just enable it? Imo going through all this troub= le > > and not trying isn't really worth it ... > = > But as a separate patch with a host of tested-by and how much battery > life is improved... Ah, the joy of 10 year old batteries! Let's wait until I get all the fixes posted shall we :) There are still some left. -- = Ville Syrj=E4l=E4 Intel OTC