From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: MI_PREDICATE_RESULT_2 is HSW only
Date: Fri, 29 Nov 2013 15:51:58 +0100
Message-ID: <20131129145158.GB27344@phenom.ffwll.local>
References: <1385729772-6140-1-git-send-email-ville.syrjala@linux.intel.com>
	<20131129134844.GG27806@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com
	[209.85.215.181])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8A86BFB941
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Nov 2013 06:51:16 -0800 (PST)
Received: by mail-ea0-f181.google.com with SMTP id m10so6898024eaj.40
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 29 Nov 2013 06:51:14 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20131129134844.GG27806@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Nov 29, 2013 at 01:48:44PM +0000, Chris Wilson wrote:
> On Fri, Nov 29, 2013 at 02:56:12PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > The MI_PREDICATE_RESULT_2 register exits only on HSW. On other
> > platforms the same offset is either reserved, or contains some
> > other register. So write the register only on HSW.
> > =

> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Couldn't find a conflict, but we all agree that writing to registers
> that do not exist is just a recipe for disaster.
> =

> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Oops, actually merged this one but then accidentally replied to the vmap
fix. Both are now in -fixes.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch