From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/2] drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs Date: Mon, 2 Dec 2013 14:42:56 +0100 Message-ID: <20131202134255.GA7281@ulmo.nvidia.com> References: <1385652558-7769-1-git-send-email-damien.lespiau@intel.com> <1385652558-7769-2-git-send-email-damien.lespiau@intel.com> <20131128154952.GN27344@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1032071693==" Return-path: In-Reply-To: <20131128154952.GN27344@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1032071693== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sm4nu43k4a2Rpi4c" Content-Disposition: inline --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 28, 2013 at 04:49:52PM +0100, Daniel Vetter wrote: > On Thu, Nov 28, 2013 at 03:29:18PM +0000, Damien Lespiau wrote: > > We had some mode_valid() vfuncs returning an int, others the enum. Let's > > use the latter everywhere. > >=20 > > Signed-off-by: Damien Lespiau >=20 > Yeah, makes sense. Queued for -next, thanks for the patch. >=20 > -Daniel > > --- > > drivers/gpu/drm/i915/intel_crt.c | 5 +++-- > > drivers/gpu/drm/i915/intel_dp.c | 2 +- > > drivers/gpu/drm/i915/intel_dsi.c | 5 +++-- > > drivers/gpu/drm/i915/intel_dvo.c | 5 +++-- > > drivers/gpu/drm/i915/intel_hdmi.c | 5 +++-- > > drivers/gpu/drm/i915/intel_lvds.c | 5 +++-- > > drivers/gpu/drm/i915/intel_sdvo.c | 5 +++-- > > 7 files changed, 19 insertions(+), 13 deletions(-) Shouldn't you be updating all other drivers as well? GCC doesn't seem to complain about it, but it's still an inconsistency. Thierry --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSnI5fAAoJEN0jrNd/PrOhWXAQAJ0XIMyUVS37ULX+FXxlMAIJ WNuBZ2faBXUvA+4uX5cMjNoRCryYWwhX4J6owXV8gM8pAGvXIdotnhI4ttiUer5z ub/nXDr4iY7U1Wbfz+dCAC0tCMFYLgiBsaynUG1bpf7ykeifijHIKfj56kt2iUC5 59DpGPvFDFX3Y7QH8b9RuZ02zAscf7DULBy4SR0VE0zmNz4qaj1xjIU6LSeR6qTz QHigVJm6P3NmwHLJqa4gklGT7mgWl/4P7+21vJyrq+jW1aMgXaNCy9Qfs+BgQVck bt5iNfp9u/70NaodBjxWadDcQ1EmGHOhTR6Ax8D9sYmaV1S5fIQt4ungjn46xl9J Oj+Pg0QlNQdGzIPf4mKdgWuOBFCbkfGzmcTf/9JIjh+xSX7Q5VKvNXwmE30EoRk2 v0k5JVLXOY9BmTyhFKi8MpdrCRNwHkWVJV95cAMbRXMEYAm8lChhrR2AWl9cFGuY +ZSxWwofkIrNap6CbZQqucSBge3sQKnRNcgrHPHkMjzaM77SDximlzm+TeUN+o8L 1hIAfYhO993LYSKsy6wajsf2/QfdxLY9LXkwGdV/EbxhyaQpSekNHvwpeHsAMC67 KbnmkOQVUdHyMneAezfwzYnokaAjhEwXCUlkp5sMU+f6I3zOPGJlfRjRDYmGodzO MDfcfoxarO0j6bArkJdJ =BZpy -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c-- --===============1032071693== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1032071693==--