Re: [PATCH 3/6] drm/i915: Downgrade pipe state mismatches to DRM_DEBUG_KMS

Daniel Vetter
2013-12-05T11:48:20Z

On Mon, Dec 02, 2013 at 11:26:08AM -0200, Rodrigo Vivi wrote:
> From: Adam Jackson <ajax@redhat.com>
>
> This is, by far, the most common kernel retrace in i915 I'm seeing:
>
> https://retrace.fedoraproject.org/faf/problems/1346879/
>
> There's not enough information in the backtrace to know if something
> actually went wrong or if this is just an assertion failure, so it's
> pretty useless. Downgrade this to DRM_DEBUG_KMS so we can still see it
> if we want it.
>
> Signed-off-by: Adam Jackson <ajax@redhat.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

Nacked. I want these reports, and if the default dmesg spam doesn't
contain enough information to make those actionable then we need to fix
that. Atm our approach is to just ask for a drm.debug=0xe log reproducing
the issue, which contains all the relevant information.

If distros don't want to bother, then they can carry this locally.
-Daniel

> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 035588a..a403611 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9463,7 +9463,7 @@ check_crtc_state(struct drm_device *dev)
>
> if (active &&
> !intel_pipe_config_compare(dev, &crtc->config, &pipe_config)) {
> - WARN(1, "pipe state doesn't match!\n");
> + DRM_DEBUG_KMS("pipe state doesn't match!\n");
> intel_dump_pipe_config(crtc, &pipe_config,
> "[hw state]");
> intel_dump_pipe_config(crtc, &crtc->config,
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch