From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk for gen2 platforms Date: Wed, 4 Dec 2013 16:15:50 +0100 Message-ID: <20131204151550.GA5502@gmail.com> References: <1386085793-317-1-git-send-email-ville.syrjala@linux.intel.com> <1386085793-317-3-git-send-email-ville.syrjala@linux.intel.com> <20131204090814.GA32218@gmail.com> <20131204151213.GW10036@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131204151213.GW10036@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org * Ville Syrj=E4l=E4 wrote: > On Wed, Dec 04, 2013 at 10:08:14AM +0100, Ingo Molnar wrote: > >=20 > > * ville.syrjala@linux.intel.com wro= te: > >=20 > > > v2: Rewrite to use the TOM-TSEG_SIZE-stolen_size and TOUD methods > >=20 > > I guess v2 is a reaction to my review feedback? I got no reply to m= y=20 > > mail from you so I'm not sure and I'd like to know whether all=20 > > feedback was addressed. >=20 > Actually this was mostly insipired by a private mail from hpa. I forg= ot > to reply to your mail, sorry about that. >=20 > But anyways, I think apart from your comment about the KB/MB macros, > the rest of the comments no longer apply. [...] Ok. > [...] And as far as those macros go, there seem to be similar macros=20 > already sprinkled around in various places, so I'm not sure how big=20 > of a fallout we'd have if I just stick them into kernel.h. That was a separate suggestion, outside the scope of this series. Anyway, this v2 series looks good. Thanks, Ingo