From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/14] drm/i915: Disable LP1+ watermarks safely in init Date: Thu, 5 Dec 2013 16:41:46 +0200 Message-ID: <20131205144146.GB10036@intel.com> References: <1386251501-10602-1-git-send-email-ville.syrjala@linux.intel.com> <1386251501-10602-11-git-send-email-ville.syrjala@linux.intel.com> <20131205142714.GF3197@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B2DE7FB96D for ; Thu, 5 Dec 2013 06:41:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131205142714.GF3197@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Dec 05, 2013 at 02:27:14PM +0000, Chris Wilson wrote: > On Thu, Dec 05, 2013 at 03:51:37PM +0200, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > ILK doesn't like if we just write the LP1+ watermarks registers with 0. > > We need to just disable the watermarks by clearing the enable bit. Use > > that method also when disabling LP1+ watermarks in init_clock_gating. > = > Mind clarifying what error is reported under the current method? I > presume this patch removes another cause of underruns. Yeah you may get an underrun and a nice glitch on the screen to go with it. -- = Ville Syrj=E4l=E4 Intel OTC