From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [Intel gfx][i-g-t PATCH 1/4] lib: Clean the batch
 buffer store after reset
Date: Fri, 6 Dec 2013 13:03:57 +0000
Message-ID: <20131206130357.GD16277@strange.amr.corp.intel.com>
References: <1386320087-3017-1-git-send-email-haihao.xiang@intel.com>
	<52A1A39C.6000905@whitecape.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id DFBF1FBC7A
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  6 Dec 2013 05:03:59 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <52A1A39C.6000905@whitecape.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Dec 06, 2013 at 02:14:52AM -0800, Kenneth Graunke wrote:
> On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> > 
> > Otherwise the stale data in the buffer
> > 
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > ---
> >  lib/intel_batchbuffer.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> > index 06a5437..9ce7424 100644
> > --- a/lib/intel_batchbuffer.c
> > +++ b/lib/intel_batchbuffer.c
> > @@ -50,6 +50,8 @@ intel_batchbuffer_reset(struct intel_batchbuffer *batch)
> >  	batch->bo = drm_intel_bo_alloc(batch->bufmgr, "batchbuffer",
> >  				       BATCH_SZ, 4096);
> >  
> > +	memset(batch->buffer, 0, sizeof(batch->buffer));
> > +
> >  	batch->ptr = batch->buffer;
> >  }
> >  
> > 
> 
> I don't think that should be harmful, but this would definitely make
> debugging nicer.  For intel-gpu-tools, I think it makes sense.
> 
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Indeed, I think it makes sense as well, thanks for the patch and review, pushed.

-- 
Damien