From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [Intel gfx][i-g-t PATCH 2/4] rendercopy/bdw: Set
 Instruction Buffer size Modify Enable to 1
Date: Fri, 6 Dec 2013 13:08:27 +0000
Message-ID: <20131206130827.GE16277@strange.amr.corp.intel.com>
References: <1386320087-3017-1-git-send-email-haihao.xiang@intel.com>
	<1386320087-3017-2-git-send-email-haihao.xiang@intel.com>
	<52A1A3B6.1040501@whitecape.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4DE58FA703
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  6 Dec 2013 05:08:29 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <52A1A3B6.1040501@whitecape.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Dec 06, 2013 at 02:15:18AM -0800, Kenneth Graunke wrote:
> On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> > 
> > Otherwise it may result in GPU hang
> > 
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > ---
> >  lib/rendercopy_gen8.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
> > index 43e962c..1a137dd 100644
> > --- a/lib/rendercopy_gen8.c
> > +++ b/lib/rendercopy_gen8.c
> > @@ -526,7 +526,7 @@ gen8_emit_state_base_address(struct intel_batchbuffer *batch) {
> >  	/* indirect object buffer size */
> >  	OUT_BATCH(0xfffff000 | 1);
> >  	/* intruction buffer size */
> > -	OUT_BATCH(1 << 12);
> > +	OUT_BATCH(1 << 12 | 1);
> >  }
> >  
> >  static void
> > 
> 
> Thanks a ton for finding this!
> 
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Nice catch! Thanks for the patch and review, pushed.

-- 
Damien