From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] drm/i915: Don't cast away const from infoframe buffer Date: Tue, 10 Dec 2013 12:25:26 +0000 Message-ID: <20131210122526.GC27411@strange.amr.corp.intel.com> References: <1386677190-7217-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A2AEFB371 for ; Tue, 10 Dec 2013 04:25:48 -0800 (PST) Content-Disposition: inline In-Reply-To: <1386677190-7217-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Dec 10, 2013 at 02:06:30PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > We don't modify the packed infoframe data, so we should keep the > const qualifier in place. Just pass the buffer as 'const void *' > instead of 'const uint8_t *' and we can drop the cast entirely. > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Damien Lespiau (I guess the data argument of intel_sdvo_write_infoframe() could be constified as well) -- = Damien > --- > drivers/gpu/drm/i915/intel_drv.h | 2 +- > drivers/gpu/drm/i915/intel_hdmi.c | 20 ++++++++++---------- > 2 files changed, 11 insertions(+), 11 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/inte= l_drv.h > index ea62673..852ed41 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -454,7 +454,7 @@ struct intel_hdmi { > bool rgb_quant_range_selectable; > void (*write_infoframe)(struct drm_encoder *encoder, > enum hdmi_infoframe_type type, > - const uint8_t *frame, ssize_t len); > + const void *frame, ssize_t len); > void (*set_infoframes)(struct drm_encoder *encoder, > struct drm_display_mode *adjusted_mode); > }; > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/int= el_hdmi.c > index 6a6ad0c..6db0d9d 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -130,9 +130,9 @@ static u32 hsw_infoframe_data_reg(enum hdmi_infoframe= _type type, > = > static void g4x_write_infoframe(struct drm_encoder *encoder, > enum hdmi_infoframe_type type, > - const uint8_t *frame, ssize_t len) > + const void *frame, ssize_t len) > { > - uint32_t *data =3D (uint32_t *)frame; > + const uint32_t *data =3D frame; > struct drm_device *dev =3D encoder->dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > u32 val =3D I915_READ(VIDEO_DIP_CTL); > @@ -167,9 +167,9 @@ static void g4x_write_infoframe(struct drm_encoder *e= ncoder, > = > static void ibx_write_infoframe(struct drm_encoder *encoder, > enum hdmi_infoframe_type type, > - const uint8_t *frame, ssize_t len) > + const void *frame, ssize_t len) > { > - uint32_t *data =3D (uint32_t *)frame; > + const uint32_t *data =3D frame; > struct drm_device *dev =3D encoder->dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > struct intel_crtc *intel_crtc =3D to_intel_crtc(encoder->crtc); > @@ -205,9 +205,9 @@ static void ibx_write_infoframe(struct drm_encoder *e= ncoder, > = > static void cpt_write_infoframe(struct drm_encoder *encoder, > enum hdmi_infoframe_type type, > - const uint8_t *frame, ssize_t len) > + const void *frame, ssize_t len) > { > - uint32_t *data =3D (uint32_t *)frame; > + const uint32_t *data =3D frame; > struct drm_device *dev =3D encoder->dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > struct intel_crtc *intel_crtc =3D to_intel_crtc(encoder->crtc); > @@ -246,9 +246,9 @@ static void cpt_write_infoframe(struct drm_encoder *e= ncoder, > = > static void vlv_write_infoframe(struct drm_encoder *encoder, > enum hdmi_infoframe_type type, > - const uint8_t *frame, ssize_t len) > + const void *frame, ssize_t len) > { > - uint32_t *data =3D (uint32_t *)frame; > + const uint32_t *data =3D frame; > struct drm_device *dev =3D encoder->dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > struct intel_crtc *intel_crtc =3D to_intel_crtc(encoder->crtc); > @@ -284,9 +284,9 @@ static void vlv_write_infoframe(struct drm_encoder *e= ncoder, > = > static void hsw_write_infoframe(struct drm_encoder *encoder, > enum hdmi_infoframe_type type, > - const uint8_t *frame, ssize_t len) > + const void *frame, ssize_t len) > { > - uint32_t *data =3D (uint32_t *)frame; > + const uint32_t *data =3D frame; > struct drm_device *dev =3D encoder->dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > struct intel_crtc *intel_crtc =3D to_intel_crtc(encoder->crtc); > -- = > 1.8.3.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx