From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 1/6] drm/i915: unconditionally copy mode
 into crtc at boot time
Date: Thu, 12 Dec 2013 13:29:39 -0800
Message-ID: <20131212132939.3dc7993f@jbarnes-desktop>
References: <1386880917-2951-1-git-send-email-jbarnes@virtuousgeek.org>
	<20131212212129.GR9804@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from alt-proxy33.mail.unifiedlayer.com
	(alt-proxy33.mail.unifiedlayer.com [70.40.209.146])
	by gabe.freedesktop.org (Postfix) with SMTP id 9231AFA7FB
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 13:27:56 -0800 (PST)
In-Reply-To: <20131212212129.GR9804@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 12 Dec 2013 22:21:29 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Thu, Dec 12, 2013 at 12:41:52PM -0800, Jesse Barnes wrote:
> > The BIOS code will need this to properly inherit the mode.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index af3717a..1ae3d44 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -11175,7 +11175,7 @@ void intel_modeset_setup_hw_state(struct drm_device *dev,
> >  	 */
> >  	list_for_each_entry(crtc, &dev->mode_config.crtc_list,
> >  			    base.head) {
> > -		if (crtc->active && i915_fastboot) {
> > +		if (crtc->active) {
> 
> That's just enabling half of the fastboot hack, so nacked.

This part isn't the hack, but is required for fastboot.  Without this,
we'll end up with a bogus mode when we try to inherit from the BIOS.
So if you want to nack this I'll have to put the other BIOS bits under
fastboot as well.

-- 
Jesse Barnes, Intel Open Source Technology Center