From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: split intel_ddi_pll_mode_set in 2
 pieces
Date: Thu, 12 Dec 2013 15:31:32 +0100
Message-ID: <20131212143132.GJ9804@phenom.ffwll.local>
References: <20131118120647.GB10162@strange.amr.corp.intel.com>
	<1385400428-1597-1-git-send-email-przanoni@gmail.com>
	<20131212101416.GC18800@strange.amr.corp.intel.com>
	<CA+gsUGRk0peP1kvz7OW-q5thb2BXhfXMKGuHfnGQtNq59UPwzw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com
	[209.85.215.170])
	by gabe.freedesktop.org (Postfix) with ESMTP id 322AFFA83B
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 06:30:43 -0800 (PST)
Received: by mail-ea0-f170.google.com with SMTP id k10so275872eaj.15
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 06:30:40 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CA+gsUGRk0peP1kvz7OW-q5thb2BXhfXMKGuHfnGQtNq59UPwzw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Dec 12, 2013 at 11:17:39AM -0200, Paulo Zanoni wrote:
> 2013/12/12 Damien Lespiau <damien.lespiau@intel.com>:
> > On Mon, Nov 25, 2013 at 03:27:08PM -0200, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> The first piece, intel_ddi_pll_select, finds a PLL and assigns it to
> >> the CRTC, but doesn't write any register. It can also fail in case it
> >> doesn't find a PLL.
> >>
> >> The second piece, intel_ddi_pll_enable, uses the information stored by
> >> intel_ddi_pll_select to actually enable the PLL by writing to its
> >> register. This function can't fail. We also have some refcount sanity
> >> checks here.
> >>
> >> The idea is that one day we'll remove all the functions that touch
> >> registers from haswell_crtc_mode_set to haswell_crtc_enable, so we'll
> >> call intel_ddi_pll_select at haswell_crtc_mode_set and then call
> >> intel_ddi_pll_enable at haswell_crtc_enable. Since I'm already
> >> touching this code, let's take care of this particular split today.
> >>
> >> v2: - Clock on the debug message is in KHz
> >>     - Add missing POSTING_READ
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> >
> > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> >
> > /*
> >  * As a side note, CodingStyle stipulates this is the preferred style
> >  * for multi-line comments. Really a small detail to keep in my in the
> >  * future :)
> >  */
> 
> I know, but our internal documentation says that "Multi-line comment
> delimiters (i.e. /* and */) do not need to be on empty lines.", so I
> was following this recommendation.

Documentation is now fixed (and also comments updated in the patch).

> Thanks for the review!

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch