From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/8] drm/i915: FBC_CONTROL2 is gen4 only
Date: Thu, 12 Dec 2013 15:59:50 +0100
Message-ID: <20131212145950.GL9804@phenom.ffwll.local>
References: <1385652602-8528-1-git-send-email-ville.syrjala@linux.intel.com>
	<1385652602-8528-4-git-send-email-ville.syrjala@linux.intel.com>
	<20131129140152.GN27806@nuc-i3427.alporthouse.com>
	<1386853242.6866.2.camel@intelbox>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53])
	by gabe.freedesktop.org (Postfix) with ESMTP id 663FEFA752
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 06:58:59 -0800 (PST)
Received: by mail-ee0-f53.google.com with SMTP id b57so286658eek.26
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 06:58:58 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1386853242.6866.2.camel@intelbox>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Dec 12, 2013 at 03:00:42PM +0200, Imre Deak wrote:
> On Fri, 2013-11-29 at 14:01 +0000, Chris Wilson wrote:
> > On Thu, Nov 28, 2013 at 05:29:57PM +0200, ville.syrjala@linux.intel.com=
 wrote:
> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > =

> > > Gen2 and gen3 don't have the FBC_CONTROL2 register, so don't
> > > touch it.
> > > =

> > > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Hmm, another instance in i915_suspend.c
> =

> Ville said he'll follow up with a separate fix for that, so:

Imo the right fix for that code is to disable it for modeset drivers and
make sure we restore everything in the normal modeset paths. There's very
little gunk left in there that we actually need, so every time we touch
this we should make some forward progress to it's ultimate demise.
-Daniel

> Reviewed-by: Imre Deak <imre.deak@intel.com>
> =

> > -Chris
> > =

> =




> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx


-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch